Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-24313][SQL][BACKPORT-2.3] Fix collection operations' interpreted evaluation for complex types #21407

Closed
wants to merge 2 commits into from

Conversation

mgaido91
Copy link
Contributor

What changes were proposed in this pull request?

The interpreted evaluation of several collection operations works only for simple datatypes. For complex data types, for instance, array_contains it returns always false. The list of the affected functions is array_contains and GetMapValue.

The PR fixes the behavior for all the datatypes.

How was this patch tested?

added UT

…ed evaluation for complex types

The interpreted evaluation of several collection operations works only for simple datatypes. For complex data types, for instance, `array_contains` it returns always `false`. The list of the affected functions is `array_contains`, `array_position`, `element_at` and `GetMapValue`.

The PR fixes the behavior for all the datatypes.

added UT

Author: Marco Gaido <[email protected]>

Closes apache#21361 from mgaido91/SPARK-24313.
@SparkQA
Copy link

SparkQA commented May 23, 2018

Test build #91025 has finished for PR 21407 at commit 9c554d4.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mgaido91
Copy link
Contributor Author

cc @cloud-fan

@SparkQA
Copy link

SparkQA commented May 23, 2018

Test build #91026 has finished for PR 21407 at commit dfaad1b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request May 23, 2018
…ed evaluation for complex types

## What changes were proposed in this pull request?

The interpreted evaluation of several collection operations works only for simple datatypes. For complex data types, for instance, `array_contains` it returns always `false`. The list of the affected functions is `array_contains` and `GetMapValue`.

The PR fixes the behavior for all the datatypes.

## How was this patch tested?

added UT

Author: Marco Gaido <[email protected]>

Closes #21407 from mgaido91/SPARK-24313_2.3.
@cloud-fan
Copy link
Contributor

thanks, merging to 2.3!

@mgaido91 mgaido91 closed this May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants