[SPARK-23080][SQL] Improve error message for built-in functions #20271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #86136 has finished for PR 20271 at commit
|
|
retest this please |
| @@ -89,7 +89,7 @@ class UDFSuite extends QueryTest with SharedSQLContext { | |||
| spark.udf.register("foo", (_: String).length) | |||
| df.selectExpr("foo(2, 3, 4)") | |||
| } | |||
| assert(e.getMessage.contains("Invalid number of arguments for function foo")) | |||
| assert(e.getMessage.contains("Invalid number of arguments for function foo. Expected:")) | |||
There was a problem hiding this comment.
nit. If we want to update all occurrence, there is one more here in StringFunctionSuite.
dongjoon-hyun
approved these changes
Jan 15, 2018
|
Test build #86139 has finished for PR 20271 at commit
|
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Jan 16, 2018
## What changes were proposed in this pull request? When a user puts the wrong number of parameters in a function, an AnalysisException is thrown. If the function is a UDF, he user is told how many parameters the function expected and how many he/she put. If the function, instead, is a built-in one, no information about the number of parameters expected and the actual one is provided. This can help in some cases, to debug the errors (eg. bad quotes escaping may lead to a different number of parameters than expected, etc. etc.) The PR adds the information about the number of parameters passed and the expected one, analogously to what happens for UDF. ## How was this patch tested? modified existing UT + manual test Author: Marco Gaido <[email protected]> Closes #20271 from mgaido91/SPARK-23080. (cherry picked from commit 8ab2d7e) Signed-off-by: hyukjinkwon <[email protected]>
|
Merged to master and branch-2.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a user puts the wrong number of parameters in a function, an AnalysisException is thrown. If the function is a UDF, he user is told how many parameters the function expected and how many he/she put. If the function, instead, is a built-in one, no information about the number of parameters expected and the actual one is provided. This can help in some cases, to debug the errors (eg. bad quotes escaping may lead to a different number of parameters than expected, etc. etc.)
The PR adds the information about the number of parameters passed and the expected one, analogously to what happens for UDF.
How was this patch tested?
modified existing UT + manual test