[SPARK-23079][SQL] Fix query constraints propagation with aliases #20270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #86135 has finished for PR 20270 at commit
|
gatorsmile
reviewed
Jan 15, 2018
| /** | ||
| * Infers an additional set of constraints from a given set of equality constraints. | ||
| * For e.g., if an operator has constraints of the form (`a = 5`, `a = b`), this returns an | ||
| * additional constraint of the form `b = 5`. | ||
| */ | ||
| private def inferAdditionalConstraints(constraints: Set[Expression]): Set[Expression] = { | ||
| val aliasedConstraints = eliminateAliasedExpressionInConstraints(constraints) |
gengliangwang
force-pushed
the
FixConstraint
branch
from
e9dd769 to
8a22e1d
Compare
|
Test build #86173 has started for PR 20270 at commit |
gengliangwang
force-pushed
the
FixConstraint
branch
from
05c32bf to
aaad66a
Compare
|
Test build #86175 has started for PR 20270 at commit |
|
Test build #86176 has started for PR 20270 at commit |
gengliangwang
changed the title
|
retest this please |
|
Test build #86217 has finished for PR 20270 at commit
|
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Jan 17, 2018
## What changes were proposed in this pull request? Previously, PR apache#19201 fix the problem of non-converging constraints. After that PR apache#19149 improve the loop and constraints is inferred only once. So the problem of non-converging constraints is gone. However, the case below will fail. ``` spark.range(5).write.saveAsTable("t") val t = spark.read.table("t") val left = t.withColumn("xid", $"id" + lit(1)).as("x") val right = t.withColumnRenamed("id", "xid").as("y") val df = left.join(right, "xid").filter("id = 3").toDF() checkAnswer(df, Row(4, 3)) ``` Because `aliasMap` replace all the aliased child. See the test case in PR for details. This PR is to fix this bug by removing useless code for preventing non-converging constraints. It can be also fixed with apache#20270, but this is much simpler and clean up the code. ## How was this patch tested? Unit test Author: Wang Gengliang <[email protected]> Closes apache#20278 from gengliangwang/FixConstraintSimple.
asfgit
pushed a commit
that referenced
this pull request
Jan 17, 2018
## What changes were proposed in this pull request? Previously, PR #19201 fix the problem of non-converging constraints. After that PR #19149 improve the loop and constraints is inferred only once. So the problem of non-converging constraints is gone. However, the case below will fail. ``` spark.range(5).write.saveAsTable("t") val t = spark.read.table("t") val left = t.withColumn("xid", $"id" + lit(1)).as("x") val right = t.withColumnRenamed("id", "xid").as("y") val df = left.join(right, "xid").filter("id = 3").toDF() checkAnswer(df, Row(4, 3)) ``` Because `aliasMap` replace all the aliased child. See the test case in PR for details. This PR is to fix this bug by removing useless code for preventing non-converging constraints. It can be also fixed with #20270, but this is much simpler and clean up the code. ## How was this patch tested? Unit test Author: Wang Gengliang <[email protected]> Closes #20278 from gengliangwang/FixConstraintSimple. (cherry picked from commit 8598a98) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously, PR #19201 fix the problem of non-converging constraints.
However, the case below will fail.
Because
aliasMapreplace all the aliased child. See the test case in PR for details.This PR is to fix this bug by removing useless
aliasMap.Duplicated to #20278, this PR will be closed after test finished.
This PR makes sense but it takes time to understand the whole code.
How was this patch tested?
Unit test