Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-22919] Bump httpclient versions #20103

Closed

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Dec 28, 2017

Hi all,

I would like to bump the PATCH versions of both the Apache httpclient Apache httpcore. I use the SparkTC Stocator library for connecting to an object store, and I would align the versions to reduce java version mismatches. Furthermore it is good to bump these versions since they fix stability and performance issues:
https://archive.apache.org/dist/httpcomponents/httpclient/RELEASE_NOTES-4.5.x.txt
https://www.apache.org/dist/httpcomponents/httpcore/RELEASE_NOTES-4.4.x.txt

Cheers, Fokko

What changes were proposed in this pull request?

Update the versions of the httpclient and httpcore. Only update the PATCH versions, so no breaking changes.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review http://spark.apache.org/contributing.html before opening a pull request.

@srowen
Copy link
Member

srowen commented Dec 28, 2017

This should be fine, but you'll need to run the ./dev/test-dependencies.sh --replace-manfest script too.

I would like to bump the PATCH versions of both the Apache httpclient
Apache httpcore. These versions fix stability and performance issues
@Fokko Fokko force-pushed the SPARK-22919-bump-httpclient-versions branch from 4e999d9 to fe0d20a Compare December 28, 2017 19:03
@Fokko
Copy link
Contributor Author

Fokko commented Dec 28, 2017

Thanks @srowen, I've ran the command and amended the commit. Cheers

@SparkQA
Copy link

SparkQA commented Dec 28, 2017

Test build #4027 has finished for PR 20103 at commit fe0d20a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@srowen
Copy link
Member

srowen commented Dec 30, 2017

Merged to master

@asfgit asfgit closed this in fd7d141 Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants