[SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates can break when child's partitioning is not decided

[tejasapatil]

What changes were proposed in this pull request?

This is a followup PR of #19257 where @gatorsmile had left couple comments wrt code style.

How was this patch tested?

Doesn't change any functionality. Will depend on build to see if no checkstyle rules are violated.

[SparkQA]

Test build #85221 has finished for PR 20041 at commit 8c37d46.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[tejasapatil]

checked the test case failure but I dont think its related to this PR.

org.apache.spark.sql.execution.datasources.parquet.ParquetQuerySuite.(It is not a test it is a sbt.testing.SuiteSelector)
org.scalatest.exceptions.TestFailedDueToTimeoutException: The code passed to eventually never returned normally. Attempted 651 times over 10.008601144 seconds. Last failure message: There are 1 possibly leaked file streams..

[tejasapatil]

Jenkins retest this please

[SparkQA]

Test build #85239 has finished for PR 20041 at commit 8c37d46.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds no public classes.

[gengliangwang]

retest this please

[SparkQA]

Test build #85254 has finished for PR 20041 at commit 8c37d46.

• This patch fails PySpark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gengliangwang]

retest this please

[SparkQA]

Test build #85265 has finished for PR 20041 at commit 8c37d46.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

LGTM

Thanks! Merged to master.