[Spark QA] [WIP] Include commit hash in Spark QA messages #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RAT and PEP8 checks don’t print a blank line after successful runs. The scalastyle check shouldn’t either.
This guy just runs the pep8 utility on all code in the python directory, minus cloudpickle, which is a 3rd-party library.
This guy just calls scalastyle.
Mostly done using autopep8, plus some hand fixes.
*fingers crossed* I admit I’m not exactly sure how this works… Let’s see if I did the right thing.
merge upstream changes
Minor, I know.
Everything looks cramped and it’s hard to tell at a glance where sections begin. Adding a blank line between sections should fix that.
See the discussion here: #1744 (comment) Get the pep8 utility at runtime so that it’s not required to be installed on the build server.
Don’t just assume curl got the file alright. Check and exit properly if there were any problems.
“then” goes on the same line as the opening “if”.
merge upstream changes
No need to exclude files in the call to pep8. The tool references tox.ini for config information, so we should use that.
“Undo” unnecessary line breaks introduced by accident when I called autopep8 on the whole Python directory without setting the max line length to 100. (autopep8 defaults to 79.)
[SPARK-1687] [PySpark] fix unit tests related to pickable namedtuple
PEP 8 is the bee’s knees.
merge upstream changes
merge upstream changes
merge upstream changes
|
It looks like this PR pulled in a bunch of unrelated commits. Do you mind closing this, creating a new feature branch containing only the commits you want, and opening an new PR from that branch? |
|
No problem. Will do. |
asfgit
pushed a commit
that referenced
this pull request
Aug 15, 2014
You can find the [discussion that motivated this PR here](http://mail-archives.apache.org/mod_mbox/spark-dev/201408.mbox/%3CCABPQxssy0ri2QAz=cc9Tx+EXYWARm7pNcVm8apqCwc-esLbO4Qmail.gmail.com%3E). As described in [SPARK-2912](https://issues.apache.org/jira/browse/SPARK-2912), the goal of this PR (and related ones to come) is to include useful detail in Spark QA's messages that are intended to make a committer's job easier to do. Since this work depends on Jenkins, I cannot test this locally. Hence, I will be iterating via this PR. Notes: * This is a duplicate of a [previous PR](#1811), without the extraneous commits. * This PR also resolves an issue targeted by [another open PR](#1809). Closes #1809. Author: Nicholas Chammas <[email protected]> Author: nchammas <[email protected]> Closes #1816 from nchammas/master and squashes the following commits: c1be644 [Nicholas Chammas] [SPARK-2912] include commit hash in messages 8f641ac [nchammas] Merge pull request #7 from apache/master
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
You can find the [discussion that motivated this PR here](http://mail-archives.apache.org/mod_mbox/spark-dev/201408.mbox/%3CCABPQxssy0ri2QAz=cc9Tx+EXYWARm7pNcVm8apqCwc-esLbO4Qmail.gmail.com%3E). As described in [SPARK-2912](https://issues.apache.org/jira/browse/SPARK-2912), the goal of this PR (and related ones to come) is to include useful detail in Spark QA's messages that are intended to make a committer's job easier to do. Since this work depends on Jenkins, I cannot test this locally. Hence, I will be iterating via this PR. Notes: * This is a duplicate of a [previous PR](apache#1811), without the extraneous commits. * This PR also resolves an issue targeted by [another open PR](apache#1809). Closes apache#1809. Author: Nicholas Chammas <[email protected]> Author: nchammas <[email protected]> Closes apache#1816 from nchammas/master and squashes the following commits: c1be644 [Nicholas Chammas] [SPARK-2912] include commit hash in messages 8f641ac [nchammas] Merge pull request apache#7 from apache/master
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no JIRA issue for this PR, but you can find the motivating discussion here. This is a work in progress.
The goal of this PR (and related ones to come) is to include useful detail in Spark QA's messages that are intended to make a committer's job easier to do.
Since this work depends on Jenkins, I cannot test this locally. Hence, I will be iterating via this PR.