[SPARK-20549] 'java.io.CharConversionException: Invalid UTF-32' in JsonToStructs #17826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Test build #76366 has finished for PR 17826 at commit
|
|
thanks, merging to master/2.2! |
asfgit
pushed a commit
that referenced
this pull request
May 2, 2017
…nToStructs ## What changes were proposed in this pull request? A fix for the same problem was made in #17693 but ignored `JsonToStructs`. This PR uses the same fix for `JsonToStructs`. ## How was this patch tested? Regression test Author: Burak Yavuz <[email protected]> Closes #17826 from brkyvz/SPARK-20549. (cherry picked from commit 86174ea) Signed-off-by: Wenchen Fan <[email protected]>
|
Hi @cloud-fan and @brkyvz, just while checking related issues with it just for my curiosity, I just realised that we are throwing an exception in XML related expressions as below: scala> sql("SELECT xpath_string('<a><b>b</b><c>cc</c></','a/c')").show()
...
java.lang.RuntimeException: Invalid XML document: org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 23; XML document structures must start and end within the same entity.
<a><b>b</b><c>cc</c></
at org.apache.spark.sql.catalyst.expressions.xml.UDFXPathUtil.eval(UDFXPathUtil.java:72)
at org.apache.spark.sql.catalyst.expressions.xml.UDFXPathUtil.evalString(UDFXPathUtil.java:81)
at org.apache.spark.sql.catalyst.expressions.xml.XPathString.nullSafeEval(xpath.scala:186)
...Should we fix these expressions too to return |
|
I'm not sure what's the semantic of |
|
Maybe let me leave this out for now until someone raises an issue about this again. Thank you for your response @cloud-fan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A fix for the same problem was made in #17693 but ignored
JsonToStructs. This PR uses the same fix forJsonToStructs.How was this patch tested?
Regression test