Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-17647][SQL][FOLLOWUP][MINOR] fix typo #17663

Closed
wants to merge 1 commit into from
Closed

[SPARK-17647][SQL][FOLLOWUP][MINOR] fix typo #17663

wants to merge 1 commit into from

Conversation

felixcheung
Copy link
Member

What changes were proposed in this pull request?

fix typo

How was this patch tested?

manual

vundela
vundela approved these changes Apr 17, 2017
View reviewed changes
Copy link

@vundela vundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this felixcheung. LGTM

@SparkQA
Copy link

SparkQA commented Apr 17, 2017

Test build #75866 has finished for PR 17663 at commit daa3c42.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Apr 18, 2017 •
edited
Loading

@felixcheung, the changes are fine to me too but I think we might need to give another scan to find such typos at least in the module or file. I am just worried if small typo PR merged as a reference can be a proper example and many people start to open PRs fixing typos (this is just what I have felt). I am worried of review/merge/test cost too.

@felixcheung
Copy link
Member Author

felixcheung commented Apr 18, 2017 •
edited
Loading

sure, I agree completely, but the reason I opened this PR was because this just went in today with this comment missed. (see JIRA above and its PR)

This isn't a random fix-this-typo PR. I wouldn't suggest or try to fix individual typo otherwise

@HyukjinKwon
Copy link
Member

Yea, I just had to note this just in case someone refers this as a reference. Thanks for bearing with me.

@felixcheung
Copy link
Member Author

felixcheung commented Apr 18, 2017 •
edited
Loading

got it. this was why I answered in details here too.

to be clear, don't open a JIRA and a PR for one typo ;)

@asfgit asfgit closed this in b0a1e93 Apr 18, 2017
@felixcheung
Copy link
Member Author

merged to master/2.1

asfgit pushed a commit that referenced this pull request Apr 18, 2017
@felixcheung
[SPARK-17647][SQL][FOLLOWUP][MINOR] fix typo
a4c1ebc 
## What changes were proposed in this pull request?

fix typo

## How was this patch tested?

manual

Author: Felix Cheung <[email protected]>

Closes #17663 from felixcheung/likedoctypo.

(cherry picked from commit b0a1e93)
Signed-off-by: Felix Cheung <[email protected]>
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
@felixcheung
[SPARK-17647][SQL][FOLLOWUP][MINOR] fix typo
20e2eef 
## What changes were proposed in this pull request?

fix typo

## How was this patch tested?

manual

Author: Felix Cheung <[email protected]>

Closes apache#17663 from felixcheung/likedoctypo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vundela vundela vundela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixcheung @SparkQA @HyukjinKwon @vundela