[SPARK-20245][SQL][minor] pass output to LogicalRelation directly #17552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gatorsmile |
cloud-fan
commented
Apr 6, 2017
| @@ -75,13 +75,13 @@ class PathOptionSuite extends DataSourceTest with SharedSQLContext { | |||
| |USING ${classOf[TestOptionsSource].getCanonicalName} | |||
| |OPTIONS (PATH '/tmp/path') | |||
| """.stripMargin) | |||
| assert(getPathOption("src") == Some("file:/tmp/path")) | |||
| assert(getPathOption("src").map(makeQualifiedPath) == Some(makeQualifiedPath("/tmp/path"))) | |||
There was a problem hiding this comment.
These changes in this test suite are not related to this PR, just to reinforce it.
|
Test build #75578 has finished for PR 17552 at commit
|
gatorsmile
reviewed
Apr 6, 2017
| // exprId in `expectedOutputAttributes`. | ||
| // The reason is that, some relations(like parquet) will reconcile attribute names to | ||
| // workaround case insensitivity issue. | ||
| case (attr, expected) => attr.withExprId(expected.exprId) |
There was a problem hiding this comment.
It sounds like this logics mentioned in the comments is removed by this PR.
There was a problem hiding this comment.
good catch! I found this logic is only useful when converting hive tables to data source tables, so I moved the logic there: https://github.com/apache/spark/pull/17552/files#diff-ee66e11b56c21364760a5ed2b783f863R215
|
LGTM except only one comment |
|
LGTM pending Jenkins. |
|
Test build #75587 has finished for PR 17552 at commit
|
|
thanks for the review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently
LogicalRelationhas aexpectedOutputAttributesparameter, which makes it hard to reason about what the actual output is. Like other leaf nodes,LogicalRelationshould also takeoutputas a parameter, to simplify the logicHow was this patch tested?
existing tests