[SPARK-20223][SQL] Fix typo in tpcds q77.sql #17538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a typo, yes, but I wonder how this worked at all? is it not used? |
|
Test build #75541 has finished for PR 17538 at commit
|
|
@srowen There's a benchmark test |
|
retest this please |
|
@wzhfy yeah it's a dumb question maybe, but is that not run automatically and thus why it isn't caught by tests? |
|
Test build #75546 has finished for PR 17538 at commit
|
|
I think we are not running it in our test case batches. This is for performance evaluation. |
asfgit
pushed a commit
that referenced
this pull request
Apr 5, 2017
## What changes were proposed in this pull request? Fix typo in tpcds q77.sql ## How was this patch tested? N/A Author: wangzhenhua <[email protected]> Closes #17538 from wzhfy/typoQ77. (cherry picked from commit a2d8d76) Signed-off-by: Xiao Li <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Apr 5, 2017
## What changes were proposed in this pull request? Fix typo in tpcds q77.sql ## How was this patch tested? N/A Author: wangzhenhua <[email protected]> Closes #17538 from wzhfy/typoQ77. (cherry picked from commit a2d8d76) Signed-off-by: Xiao Li <[email protected]>
|
Thanks! Merging to master/2.1/2.0 |
|
@srowen It's not run automatically. And even if it is run, no error would be caught, the predicate will just become |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix typo in tpcds q77.sql
How was this patch tested?
N/A