[SPARK-3723] [MLlib] Adding instrumentation to random forests #13881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
|
Test build #61144 has finished for PR 13881 at commit
|
no groups of nodes are procesed; updated log statements to reflect this
|
Test build #61150 has finished for PR 13881 at commit
|
|
Test build #61151 has finished for PR 13881 at commit
|
|
Does it make sense to only perform instrumentation-related computations (i.e. updating the max/min nodes per group) if the instrumentation argument to RandomForest.run (instr) is not None? This isn't checked for in the current implementation. |
|
Sorry for the long delay! Whenever you get a chance to update this, it'd be nice to log this info via the Instrumentation class, rather than logInfo. |
|
Hi @smurching, is this still active? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In RandomForest.run(), added instrumentation for the number of node groups, along with the min, max, and average number of nodes per group.
Also fixed a typo in BaggedPoint.scala documentation.
How was this patch tested?
Tested by running RandomForestClassifierSuite, checking the test output manually to make sure instrumentation information was present and reasonable.