[SPARK-14926] [ML] OneVsRest labelMetadata uses incorrect name #13762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josh-howes Did you try compiling the code? |
|
Ping |
|
Test build #3251 has finished for PR 13762 at commit
|
josh-howes
force-pushed
the
Bugfix/SPARK-14926-One_vs_Rest-labelMetadata
branch
from
bd510ec to
b4badae
Compare
|
@SparkQA build |
|
I think we should close this PR. |
|
I recently pushed a change to this but @SparkQA didn't kick off an automated build. Is that because I squashed my commits? |
|
Jenkins test this please |
|
Test build #65256 has finished for PR 13762 at commit
|
jkbradley
reviewed
Oct 7, 2016
| @@ -196,8 +196,13 @@ final class OneVsRestModel private[ml] ( | |||
| } | |||
|
|
|||
| // output label and label metadata as prediction | |||
| val predictionMetadata = new MetadataBuilder() | |||
| .withMetadata(labelMetadata) | |||
| .putString("name", predictionCol.name) | |||
There was a problem hiding this comment.
This should go through the standard ML attribute constructors to modify labelMetadata:
val predictionMetadata = Attribute.fromMetadata(labelMetadata)
.withName($(predictionCol))
.toMetadata()
|
Test build #3299 has finished for PR 13762 at commit
|
|
Hi @josh-howes is it still active? If so, please address the comments above. Otherwise, I would rather like to propose to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution is my original work and I license the work to the project under the project's open source license.
What changes were proposed in this pull request?
OneVsRestModel applies labelMetadata to the output column, but the metadata could contain the wrong name. The attribute name was modified to match predictionCol.
How was this patch tested?
Manual Tests