Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-10359][PROJECT-INFRA] Multiple fixes to dev/test-dependencies.sh script #10543

Closed
wants to merge 8 commits into from

Conversation

JoshRosen
Copy link
Contributor

This patch includes multiple fixes for the dev/test-dependencies.sh script (which was introduced in #10461):

  • Use build/mvn --force instead of mvn in one additional place.
  • Explicitly set a zero exit code on success.
  • Set LC_ALL=C to make sort results agree across machines (see https://stackoverflow.com/questions/28881/).
  • Set should_run_build_tests=True for build module (this somehow got lost).

@JoshRosen
Copy link
Contributor Author

Actually, it occurred to me that I should really be setting LC_ALL=C at the top of the script to guard against future problems in case we add additional locale-sensitive command calls. Let me make that change now...

@SparkQA
Copy link

SparkQA commented Jan 1, 2016

Test build #48561 has finished for PR 10543 at commit 1844d32.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

The latest test run passed the build tests and I manually tested this on the AMP Jenkins workers, so I'm going to speculatively merge this and will re-test the failing PRs. If that doesn't work, I'll hotfix to disable this test pending real investigation.

@asfgit asfgit closed this in 5adec63 Jan 1, 2016
@JoshRosen JoshRosen deleted the dep-script-fixes branch January 1, 2016 04:25
@SparkQA
Copy link

SparkQA commented Jan 1, 2016

Test build #48562 has finished for PR 10543 at commit 58142e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

JoshRosen added a commit to JoshRosen/spark that referenced this pull request Jan 10, 2016
…sh script

This patch includes multiple fixes for the `dev/test-dependencies.sh` script (which was introduced in apache#10461):

- Use `build/mvn --force` instead of `mvn` in one additional place.
- Explicitly set a zero exit code on success.
- Set `LC_ALL=C` to make `sort` results agree across machines (see https://stackoverflow.com/questions/28881/).
- Set `should_run_build_tests=True` for `build` module (this somehow got lost).

Author: Josh Rosen <[email protected]>

Closes apache#10543 from JoshRosen/dep-script-fixes.
JoshRosen added a commit to JoshRosen/spark that referenced this pull request Jan 10, 2016
…sh script

This patch includes multiple fixes for the `dev/test-dependencies.sh` script (which was introduced in apache#10461):

- Use `build/mvn --force` instead of `mvn` in one additional place.
- Explicitly set a zero exit code on success.
- Set `LC_ALL=C` to make `sort` results agree across machines (see https://stackoverflow.com/questions/28881/).
- Set `should_run_build_tests=True` for `build` module (this somehow got lost).

Author: Josh Rosen <[email protected]>

Closes apache#10543 from JoshRosen/dep-script-fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants