From 7884e87975e8655f0e3a20cc0455e0d7cd614fe4 Mon Sep 17 00:00:00 2001 From: tedyu Date: Mon, 28 Dec 2015 12:47:26 -0800 Subject: [PATCH 1/4] Adjust coverage for partitionBy() --- .../src/main/scala/org/apache/spark/sql/DataFrameWriter.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala index 03867beb78224..3925ea59bdc6e 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala @@ -119,7 +119,7 @@ final class DataFrameWriter private[sql](df: DataFrame) { * Partitions the output by the given columns on the file system. If specified, the output is * laid out on the file system similar to Hive's partitioning scheme. * - * This is only applicable for Parquet at the moment. + * This was initally applicable for Parquet but in 1.5.x covers JSON as well. * * @since 1.4.0 */ From f655bbe37fee7903ca8446996f971f629b1c5450 Mon Sep 17 00:00:00 2001 From: tedyu Date: Mon, 28 Dec 2015 15:45:09 -0800 Subject: [PATCH 2/4] Change wording for 1.5+ --- .../src/main/scala/org/apache/spark/sql/DataFrameWriter.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala index 3925ea59bdc6e..f876501b15e2c 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala @@ -119,7 +119,7 @@ final class DataFrameWriter private[sql](df: DataFrame) { * Partitions the output by the given columns on the file system. If specified, the output is * laid out on the file system similar to Hive's partitioning scheme. * - * This was initally applicable for Parquet but in 1.5.x covers JSON as well. + * This was initally applicable for Parquet but in 1.5+ covers JSON as well. * * @since 1.4.0 */ From dff3935b571bcbf121aa017b1cf52bc5757d04ab Mon Sep 17 00:00:00 2001 From: tedyu Date: Mon, 28 Dec 2015 18:27:20 -0800 Subject: [PATCH 3/4] Fix typo --- .../src/main/scala/org/apache/spark/sql/DataFrameWriter.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala index f876501b15e2c..4b5bb8d8ea2e7 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala @@ -119,7 +119,7 @@ final class DataFrameWriter private[sql](df: DataFrame) { * Partitions the output by the given columns on the file system. If specified, the output is * laid out on the file system similar to Hive's partitioning scheme. * - * This was initally applicable for Parquet but in 1.5+ covers JSON as well. + * This was initially applicable for Parquet but in 1.5+ covers JSON as well. * * @since 1.4.0 */ From a0217257878525dc59fb8cac9566ffe6390ce0d6 Mon Sep 17 00:00:00 2001 From: tedyu Date: Tue, 29 Dec 2015 18:04:07 -0800 Subject: [PATCH 4/4] Address Michael's comment --- .../src/main/scala/org/apache/spark/sql/DataFrameWriter.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala index 4b5bb8d8ea2e7..acd939e15f9b1 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala @@ -119,7 +119,7 @@ final class DataFrameWriter private[sql](df: DataFrame) { * Partitions the output by the given columns on the file system. If specified, the output is * laid out on the file system similar to Hive's partitioning scheme. * - * This was initially applicable for Parquet but in 1.5+ covers JSON as well. + * This was initially applicable for Parquet but in 1.5+ covers JSON, text, ORC and avro as well. * * @since 1.4.0 */