[SPARK-12486] Worker should kill the executors more forcefully if possible. #10438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible. This patch updates the ExecutorRunner's terminate path to use the new java 8 API to terminate processes more forcefully if possible. If the executor is unhealthy, it would previously ignore the destroy() call. Presumably, the new java API was added to handle cases like this.
|
Test build #48212 has finished for PR 10438 at commit
|
| destroyMethod.setAccessible(true) | ||
| destroyMethod.invoke(process) | ||
| } catch { | ||
| case e: Exception => { |
There was a problem hiding this comment.
in general catch NonFatal, i.e.
case NonFatal(e) => process.destroy()
|
Looks good. |
| } catch { | ||
| case e: Exception => { | ||
| process.destroy() | ||
| } |
There was a problem hiding this comment.
this might end up swallowing useful exception messages. Maybe we should catch more narrowly
case NonFatal(e) =>
if (!e.isInstanceOf[NoSuchMethodException]) {
logWarning("Exception when attempting to kill process", e)
}
process.destroy()
There was a problem hiding this comment.
+1 for narrowly catching exceptions
|
Test build #48374 has finished for PR 10438 at commit
|
| if (!e.isInstanceOf[NoSuchMethodException]) { | ||
| logWarning("Exception when attempting to kill process", e) | ||
| } else { | ||
| process.destroy() |
There was a problem hiding this comment.
don't we want to best-effort destroy the process whether or not it's a NSME?
|
test this please |
|
Test build #48398 has finished for PR 10438 at commit
|
|
Test build #48522 has finished for PR 10438 at commit
|
|
test this please |
|
Test build #48624 has finished for PR 10438 at commit
|
|
Merging into master 1.6 |
asfgit
pushed a commit
that referenced
this pull request
Jan 4, 2016
…sible. This patch updates the ExecutorRunner's terminate path to use the new java 8 API to terminate processes more forcefully if possible. If the executor is unhealthy, it would previously ignore the destroy() call. Presumably, the new java API was added to handle cases like this. We could update the termination path in the future to use OS specific commands for older java versions. Author: Nong Li <[email protected]> Closes #10438 from nongli/spark-12486-executors. (cherry picked from commit 8f65939) Signed-off-by: Andrew Or <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the ExecutorRunner's terminate path to use the new java 8 API
to terminate processes more forcefully if possible. If the executor is unhealthy,
it would previously ignore the destroy() call. Presumably, the new java API was
added to handle cases like this.
We could update the termination path in the future to use OS specific commands
for older java versions.