fix the corner case of maxmin

apache · Apr 10, 2014 · f7a3ca2 · f7a3ca2
1 parent 967d041
commit f7a3ca2
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/rdd/VectorRDDFunctions.scala b/mllib/src/main/scala/org/apache/spark/mllib/rdd/VectorRDDFunctions.scala
@@ -59,16 +59,16 @@ private class Aggregator(
 
   override def max(): Vector = {
     nnz.activeIterator.foreach {
-      case (id, 0.0) => currMax(id) = 0.0
-      case _ =>
+      case (id, count) =>
+        if ((count == 0.0) || ((count < totalCnt) && (currMax(id) < 0.0)))  currMax(id) = 0.0
     }
     Vectors.fromBreeze(currMax)
   }
 
   override def min(): Vector = {
     nnz.activeIterator.foreach {
-      case (id, 0.0) => currMin(id) = 0.0
-      case _ =>
+      case (id, count) =>
+        if ((count == 0.0) || ((count < totalCnt) && (currMin(id) > 0.0))) currMin(id) = 0.0
     }
     Vectors.fromBreeze(currMin)
   }