Skip to content

Commit

Permalink
[SPARK-22849] ivy.retrieve pattern should also consider classifier
Browse files Browse the repository at this point in the history
## What changes were proposed in this pull request?
In the previous PR #5755 (comment), we dropped `(-[classifier])` from the retrieval pattern. We should add it back; otherwise,
> If this pattern for instance doesn't has the [type] or [classifier] token, Ivy will download the source/javadoc artifacts to the same file as the regular jar.

## How was this patch tested?
The existing tests

Author: gatorsmile <[email protected]>

Closes #20037 from gatorsmile/addClassifier.
  • Loading branch information
gatorsmile committed Dec 20, 2017
1 parent d762d11 commit c89b431
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,7 @@ private[spark] object SparkSubmitUtils {
// retrieve all resolved dependencies
ivy.retrieve(rr.getModuleDescriptor.getModuleRevisionId,
packagesDirectory.getAbsolutePath + File.separator +
"[organization]_[artifact]-[revision].[ext]",
"[organization]_[artifact]-[revision](-[classifier]).[ext]",
retrieveOptions.setConfs(Array(ivyConfName)))
resolveDependencyPaths(rr.getArtifacts.toArray, packagesDirectory)
} finally {
Expand Down

0 comments on commit c89b431

Please sign in to comment.