From 40062e3e4ea490001467b85a147ae72f1ec14f4d Mon Sep 17 00:00:00 2001 From: HyukjinKwon Date: Thu, 6 Feb 2020 13:01:08 +0900 Subject: [PATCH] [SPARK-30737][SPARK-27262][R][BUILD] Reenable CRAN check with UTF-8 encoding to DESCRIPTION ### What changes were proposed in this pull request? This PR proposes to reenable CRAN check disabled at https://github.com/apache/spark/pull/27460. Given the tests https://github.com/apache/spark/pull/27468, seems we should also port https://github.com/apache/spark/pull/23823 together. ### Why are the changes needed? To check CRAN back. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? It was tested at https://github.com/apache/spark/pull/27468 and Jenkins should test it out. Closes #27472 from HyukjinKwon/SPARK-30737. Authored-by: HyukjinKwon Signed-off-by: HyukjinKwon (cherry picked from commit b95ccb1d8b726b11435789cdb5882df6643430ed) Signed-off-by: HyukjinKwon --- R/pkg/DESCRIPTION | 1 + R/pkg/tests/fulltests/test_sparkSQL.R | 7 +------ R/run-tests.sh | 7 +++---- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/R/pkg/DESCRIPTION b/R/pkg/DESCRIPTION index fffdcd29899ce..c913a38c21ff4 100644 --- a/R/pkg/DESCRIPTION +++ b/R/pkg/DESCRIPTION @@ -61,3 +61,4 @@ Collate: RoxygenNote: 5.0.1 VignetteBuilder: knitr NeedsCompilation: no +Encoding: UTF-8 diff --git a/R/pkg/tests/fulltests/test_sparkSQL.R b/R/pkg/tests/fulltests/test_sparkSQL.R index 542a2bb7e6efc..21902bc74bc46 100644 --- a/R/pkg/tests/fulltests/test_sparkSQL.R +++ b/R/pkg/tests/fulltests/test_sparkSQL.R @@ -505,12 +505,7 @@ test_that("SPARK-17811: can create DataFrame containing NA as date and time", { expect_true(is.na(DF$date[2])) expect_equal(DF$date[1], as.Date("2016-10-01")) expect_true(is.na(DF$time[2])) - # Warnings were suppressed due to Jenkins environment issues. - # It shows both warnings as below in Jenkins: - # - Your system is mis-configured: /etc/localtime is not a symlink - # - It is strongly recommended to set environment variable TZ to - # America/Los_Angeles (or equivalent) - suppressWarnings(expect_equal(DF$time[1], as.POSIXlt("2016-01-10"))) + expect_equal(DF$time[1], as.POSIXlt("2016-01-10")) }) test_that("create DataFrame with complex types", { diff --git a/R/run-tests.sh b/R/run-tests.sh index 557f121c6dded..86bd8aad5f113 100755 --- a/R/run-tests.sh +++ b/R/run-tests.sh @@ -31,10 +31,9 @@ NUM_TEST_WARNING="$(grep -c -e 'Warnings ----------------' $LOGFILE)" # Also run the documentation tests for CRAN CRAN_CHECK_LOG_FILE=$FWDIR/cran-check.out rm -f $CRAN_CHECK_LOG_FILE -# TODO(SPARK-30737) reenable this once packages are correctly installed in Jenkins -# NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE -# FAILED=$((PIPESTATUS[0]||$FAILED)) -touch $CRAN_CHECK_LOG_FILE + +NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE +FAILED=$((PIPESTATUS[0]||$FAILED)) NUM_CRAN_WARNING="$(grep -c WARNING$ $CRAN_CHECK_LOG_FILE)" NUM_CRAN_ERROR="$(grep -c ERROR$ $CRAN_CHECK_LOG_FILE)"