Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolrBackup doesn't work when the collections field is omitted #515

Closed
a-nych opened this issue Jan 12, 2023 · 1 comment · Fixed by #516
Closed

SolrBackup doesn't work when the collections field is omitted #515

a-nych opened this issue Jan 12, 2023 · 1 comment · Fixed by #516
Labels
backup bug Something isn't working
Milestone

Comments

@a-nych
Copy link
Contributor

a-nych commented Jan 12, 2023

The SolrBackup CRD has the option to specify collections for backups. However, it's not a required field. One could imagine that without specifying this field, every collection should be backed up.

On version 0.6.0 when the collection field is not configured, nothing happens within the controller, only this is being logged.

2023-01-12T12:10:37.412Z	INFO	controller-runtime.manager.controller.solrbackup	Updating status for solr-backup	{"reconciler group": "solr.apache.org", "reconciler kind": "SolrBackup", "name": "test-whole-backup", "namespace": "one-preprod", "newStatus": {"solrVersion":"8.11.2","startTimestamp":"2023-01-12T12:10:37Z"}, "oldStatus": {"startTimestamp":null}}

Solr doesn't receive any API calls.

@HoustonPutman
Copy link
Contributor

Once #507 is merged, we can add tests for this and make sure that it is good to go for the next release.

@HoustonPutman HoustonPutman added this to the main (v0.7.0) milestone Jan 24, 2023
@HoustonPutman HoustonPutman added bug Something isn't working backup labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backup bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants