Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zookeeper pod label customization not working #490

Closed
endzyme opened this issue Nov 3, 2022 · 2 comments · Fixed by #514 or #551
Closed

Zookeeper pod label customization not working #490

endzyme opened this issue Nov 3, 2022 · 2 comments · Fixed by #514 or #551
Labels
bug Something isn't working custom kube options Adding options related to customizing parts of the default Kubernetes resources. zookeeper Related to Zookeeper or the Zookeeper Operator
Milestone

Comments

@endzyme
Copy link
Contributor

endzyme commented Nov 3, 2022

Description

When trying to apply custom labels to Zookeeper pods through the SolrCloud spec, the labels do not show up on the final set of Zookeeper pods.

The issue appears to be that the Zookeeper Operator is not propagating the zookeepercluster.spec.pod.labels fields, but only applying labels which are defined in zookeepercluster.spec.labels.

Related Issues

#148
pravega/zookeeper-operator#511

Possible Solutions / Workarounds

Solution: Zookeeper Operator fixes the code to ensure the pod.labels are applied to the final StatefulSet for the Zookeeper ensemble.

Workaround: Change the Solr Operator to create the ZookeeperCluster custom resource to apply labels to zookeepercluster.spec.labels instead of zookeepercluster.spec.pod.labels.

@HoustonPutman HoustonPutman added bug Something isn't working zookeeper Related to Zookeeper or the Zookeeper Operator custom kube options Adding options related to customizing parts of the default Kubernetes resources. labels Dec 22, 2022
@HoustonPutman HoustonPutman added this to the main (v0.7.0) milestone Dec 22, 2022
@HoustonPutman
Copy link
Contributor

Thanks for finding this issue!

This sounds like a good workaround, since it doesn't look like they will fix the issue soon.

Would you mind making a PR for this?

@HoustonPutman
Copy link
Contributor

The Zookeeper Operator fix for this issue was released in v0.2.15.

Once #549 is complete, we can remove this workaround before it is released in v0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working custom kube options Adding options related to customizing parts of the default Kubernetes resources. zookeeper Related to Zookeeper or the Zookeeper Operator
Projects
None yet
2 participants