Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SolrBackup Persistence option #347

Closed
HoustonPutman opened this issue Oct 14, 2021 · 1 comment · Fixed by #357
Closed

Remove SolrBackup Persistence option #347

HoustonPutman opened this issue Oct 14, 2021 · 1 comment · Fixed by #357
Labels
Milestone

Comments

@HoustonPutman
Copy link
Contributor

With the support for GCS and S3 backups (#301, #328), we should remove the Persistence options for the SolrBackup.

It's really just a legacy option to help people store things in S3, before the S3Repository was made available. It's janky and doesn't work with the new incremental backups.

I think it would be best to just remove the option all-together.

@gerlowskija
Copy link
Contributor

+1 from me:

I think taking it out makes sense - especially if it was primarily a means of getting backups into S3 (which we now have other options for). The idea of compressing and moving backups is probably someone specific to non-incremental backups too, which are deprecated and set to go away in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants