Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podOptions probes ignored #208

Closed
makuk66 opened this issue Feb 3, 2021 · 1 comment · Fixed by #210
Closed

podOptions probes ignored #208

makuk66 opened this issue Feb 3, 2021 · 1 comment · Fixed by #210
Labels
bug Something isn't working
Milestone

Comments

@makuk66
Copy link

makuk66 commented Feb 3, 2021

I tried setting solrcloud values:

podOptions:
  livenessProbe:
    tcpSocket:
      port: 8983
    initialDelaySeconds: 5
    periodSeconds: 5
  readinessProbe:
    tcpSocket:
      port: 8983
    initialDelaySeconds: 5
    periodSeconds: 5

but these settings seemed to be ignored; the normal http-get probes were used

@HoustonPutman HoustonPutman added the bug Something isn't working label Feb 3, 2021
@HoustonPutman HoustonPutman added this to the v0.3.0 milestone Feb 3, 2021
@HoustonPutman
Copy link
Contributor

Good catch, thanks for submitting the bug!

The issue likely lies in the fact that the code for filling default values for a probe only looks for Handlers and Execs, not TcpSocket.
https://github.com/apache/lucene-solr-operator/blob/main/controllers/util/solr_util.go#L663

Should be an easy fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants