Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal]Env reset from UI #1973

Closed
wu-sheng opened this issue Nov 29, 2018 · 6 comments
Closed

[Proposal]Env reset from UI #1973

wu-sheng opened this issue Nov 29, 2018 · 6 comments
Assignees
Labels
agent Language agent related. backend OAP backend related. core feature Core and important feature. Sometimes, break backwards compatibility. UI UI and front end related.
Milestone

Comments

@wu-sheng
Copy link
Member

Hi everyone,

I have seen and known a lot, even tons of new users, have the experience of deleting the whole storage(Elastic Search), which make the metadata(including service, instance, address and endpoint inventories) not available for streaming analysis and query.

Lots of issues came from there. Also, there is a proposal to provide reset from agent settings, #1929 , which hasn't been merged.

I have kept thinking the solution in several months, discussing with several contributors, also involved in #1929 too. Now I have a new proposal

Core requirement

The key of this feature is making the whole env back to work, even the data have been deleted somehow. So back online immediately is not the high-priority requirements, convenience is.

Solution

Bring a new UI page to show

  1. List of all service and service instance. Each instance shows the agent register time and last ping time.
  2. A RESET button with a time in minutes, default in 2 mins. Which give the user a way to reset all agent core.

Tech related.

  1. We already have the Commands response in trace, JVM, ServiceInstancePing#doPing services. So the commands are open to use.
  2. UI page is not very hard. Need to add new GraphQL query to support this. @TinyAllen Any interest to help us on this? FYI @hanahmily
  3. Backend, provide a timer to this specific command, Right now, we don't consider there is a common way to do all commands. Is that all right? @peng-yongsheng . When timer find this command, asked all receivers to keep in response Commands only mode, which means don't do dispatch and clear the buffer
  4. Agent, support this command, clear buffer, queue, serviceId and service InstanceId. Also keep running in this sleep mode until time is up.

@apache/skywalking-committers @JaredTan95 I want to provide this in beta release. Look forward you feedback.

@wu-sheng wu-sheng added core feature Core and important feature. Sometimes, break backwards compatibility. agent Language agent related. backend OAP backend related. UI UI and front end related. labels Nov 29, 2018
@wu-sheng wu-sheng added this to the 6.0.0-beta milestone Nov 29, 2018
@liuhaoyang
Copy link
Member

.NET Core Agent also needs to support this feature

@R1hug0
Copy link

R1hug0 commented Nov 29, 2018

Support only in V6?

@wu-sheng
Copy link
Member Author

Support only in V6?

I think so. V5 is using SkyWalking v1 trace protocol, no command downstream. @R1hug0

@wu-sheng
Copy link
Member Author

Hi all

Because of today's discussion, @liuhaoyang is proposing to provide SQL and Cache statement analysis, such as TopSQL and execute throughputs. That is a very core feature for the end user, so I am going to move this to 6.0.0

@wu-sheng wu-sheng modified the milestones: 6.0.0-beta, 6.0.0-GA Nov 30, 2018
@wu-sheng
Copy link
Member Author

@wu-sheng
Copy link
Member Author

wu-sheng commented Jan 3, 2019

I will work on telemetry and performance tests first. Maybr this feature will be done in 6.1

@wu-sheng wu-sheng modified the milestones: 6.0.0-GA, 6.1.0 Jan 3, 2019
@wu-sheng wu-sheng modified the milestones: 6.1.0, 6.2.0 Feb 16, 2019
@wu-sheng wu-sheng modified the milestones: 6.2.0, 6.3.0 Jun 9, 2019
@wu-sheng wu-sheng closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. backend OAP backend related. core feature Core and important feature. Sometimes, break backwards compatibility. UI UI and front end related.
Projects
None yet
Development

No branches or pull requests

6 participants