-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for STRRIGHT alias in Doris (#31508) #33393
Conversation
RIGHT is already implemented and supported by both MySQL and Doris - Added parsing suppor t for the `STRRIGHT` alias in Doris - Updated existing tests to reflect that `RIGHT` is also supported by Doris - Added STRRIGHT tests - Marked `// DORIS ADDED BEGIN|END` Doris-specific changes - Added as a `regularFunctionName` which is where `RIGHT` is
I will look at the test results again as 76b9007 was supposed to fix the failing test |
also removed MySQL as target for the alias
Looks like on the most current code Waiting for that full rebuild to finish and issuing a fresh commit |
All checks passed and it looks good, just did a merge with upstream to have it up to date. Checks will be redone but not expecting any issues there. Ready to be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, merged. @danigiri Thank you for your excellent code.
Continuing with Doris parsing support.
In this case
RIGHT
is already implemented and supported by both MySQL and Doris so ammended the tests and addedSTRRIGHT
support which is an alias in Doris.Continues to address #31508.
Changes proposed in this pull request:
STRRIGHT
alias in DorisRIGHT
is also supported by DorisSTRRIGHT
-specific test// DORIS ADDED BEGIN|END
Doris-specific changes, and fixed a typo in existing oneregularFunctionName
which is whereRIGHT
is so no java changes should be neededSELECT STRRIGHT('foobarbar',4)
in Doris 3.0.2 correctlyNext
get PR id to update release notesfinish compiling Doris v3 to test the query codemy local machine is not powerful enoughBefore committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.mvn spotless:apply -Pcheck
mvn test -Dit.test=InternalDorisParserIT
inshardingsphere/parser/sql/dialect/doris
(need to specify it.test)SELECT STRRIGHT('foobarbar',4)