Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automCommit not support #2060

Closed
koalas1105 opened this issue Mar 19, 2019 · 4 comments
Closed

automCommit not support #2060

koalas1105 opened this issue Mar 19, 2019 · 4 comments

Comments

@koalas1105
Copy link

Bug Report

For English only, other languages will not accept.

Before report a bug, make sure you have:

Please pay attention on issues you submitted, because we maybe need more details.
If no response more than 7 days and we cannot reproduce it on current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Which version of ShardingSphere did you use?

3.1.0

Which project did you use? Sharding-JDBC or Sharding-Proxy?

Sharding-Proxy

Expected behavior

Exception in thread "main" Cannot create property=dataSources for JavaBean=io.shardingsphere.shardingproxy.config.yaml.YamlProxyRuleConfiguration@14899482
 in 'reader', line 11, column 1:
    schemaName: ds_1
    ^
Cannot create property=autoCommit for JavaBean=io.shardingsphere.core.rule.DataSourceParameter@11028347
 in 'reader', line 15, column 5:
        url: jdbc:mysql://127.0.0.1:3306 ...
        ^
Unable to find property 'autoCommit' on class: io.shardingsphere.core.rule.DataSourceParameter
 in 'reader', line 18, column 17:
        autoCommit: true
                    ^

 in 'reader', line 14, column 3:
      ds_0:
      ^

Actual behavior

Reason analyze (If you can)

Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.

Example codes for reproduce this issue (such as a github link).

@koalas1105
Copy link
Author

koalas1105 commented Mar 19, 2019

config-sharding-ds1.yaml

dataSources:
  ds_0:
    url: jdbc:mysql://127.0.0.1:3306/ds_1?serverTimezone=UTC&useSSL=false
    username: root
    password: Root@123
    autoCommit: true
    connectionTimeoutMilliseconds: 30000
    idleTimeoutMilliseconds: 60000
    maxLifetimeMilliseconds: 1800000
    minPoolSize: 10
    maxPoolSize: 10

@terrymanu
Copy link
Member

autoCommit is not a valid configuration item of Sharding-Proxy.
FYI: https://shardingsphere.apache.org/document/current/en/manual/sharding-proxy/configuration/

@koalas1105
Copy link
Author

3.1.0 why not support autoCommit property?

@terrymanu
Copy link
Member

Configuration item is defined by Sharding-Proxy.

autoCommit is connection or JDBC URL's property, they are different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants