Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The process queues of unsubscribed topic are not dropped #1024

Closed
wgdzlh opened this issue Mar 31, 2023 · 0 comments · Fixed by #1025
Closed

The process queues of unsubscribed topic are not dropped #1024

wgdzlh opened this issue Mar 31, 2023 · 0 comments · Fixed by #1025
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wgdzlh
Copy link
Contributor

wgdzlh commented Mar 31, 2023

BUG REPORT

  1. Unsubscribed topic still has process queues running, which should be dropped during rebalance. The problem is caused by missing function implement compared to Java version:

https://github.com/apache/rocketmq/blob/06f2208a34907211591114f6b0d327168c250fb3/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java#L232

https://github.com/apache/rocketmq/blob/06f2208a34907211591114f6b0d327168c250fb3/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java#L314
@wgdzlh wgdzlh mentioned this issue Mar 31, 2023
Merged
5 tasks
@wgdzlh wgdzlh changed the title The process queues of unsubscribed topic is not dropped The process queues of unsubscribed topic are not dropped Mar 31, 2023
@francisoliverlee francisoliverlee added bug Something isn't working good first issue Good for newcomers labels Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #1024] fix: unsubscribed topic queues not dropped wgdzlh/rocketmq-client-go
2 participants
@francisoliverlee @wgdzlh