Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][client] Fix enableRetry for consumers using legacy topic naming where cluster name is included #23753

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

crossoverJie
Copy link
Member

Motivation

Consumer consumer = pulsarClient.newConsumer()
                .topic("persistent://prop/use/ns-abc1/topic-1")
                .subscriptionName("my-sub")
                .subscriptionType(SubscriptionType.Shared)
                .enableRetry(true)
                .ackTimeout(ackTimeOutMillis, TimeUnit.MILLISECONDS)
                .subscribe();

When enableRetry with cluster topic, an exception will be thrown:
image

Modifications

Use this TopicName#get(java.lang.String, org.apache.pulsar.common.naming.NamespaceName, java.lang.String) to obtain the topic name.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@crossoverJie crossoverJie requested a review from lhotari December 18, 2024 09:28
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 18, 2024
@lhotari lhotari changed the title [improve][client] EnableRetry for cluster topic compatibility. [fix][client] Fix enableRetry for consumers using legacy topic naming where cluster name is included Dec 20, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari added this to the 4.1.0 milestone Dec 20, 2024
@lhotari lhotari merged commit 217ebfb into apache:master Dec 20, 2024
61 checks passed
lhotari pushed a commit that referenced this pull request Dec 21, 2024
… where cluster name is included (#23753)

(cherry picked from commit 217ebfb)
lhotari pushed a commit that referenced this pull request Dec 21, 2024
… where cluster name is included (#23753)

(cherry picked from commit 217ebfb)
lhotari pushed a commit that referenced this pull request Dec 21, 2024
… where cluster name is included (#23753)

(cherry picked from commit 217ebfb)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 26, 2024
… where cluster name is included (apache#23753)

(cherry picked from commit 217ebfb)
(cherry picked from commit 2d0089e)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 26, 2024
… where cluster name is included (apache#23753)

(cherry picked from commit 217ebfb)
(cherry picked from commit 2d0089e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants