-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prebuilt C++ client to reduce test time for build image #9374
Comments
@Renkai Are you working on this issue? |
@jiazhai Sure, I'm working on it |
Thanks, will assign it to you |
Maybe we can build a Debian package and upload it to somewhere every time the C++ client code updated, then retrieve it back when the integration test needs the debian package |
The only reason we compile the C++ library for the Docker images is to include the Python client library, so that Python function can be executed in the Docker containers. For CI tests purposes, it would be ok to use a snapshot of the Python lib. We could be pushing a nightly wheel file to the Apache Snapshot maven repo and fetch it from there in the integration tests. The thing to be careful though, is that the same Dockerfile are also used to prepare the images for release. In that case, we must ensure the image is containing the right library compiled from the current working copy of the sources. |
The issue had no activity for 30 days, mark with Stale label. |
IIRC we're implemented along with the move out of client C++ and Python at #17724. |
Build C++ client now use lots of GitHub actions resource in our test workflow. If we can skip this step when the C++ client code is not changed, the time to build the docker image in the integration test will be reduced significantly.
The text was updated successfully, but these errors were encountered: