From 2316e13142d803b42ac4889a68a0f38ab5858aca Mon Sep 17 00:00:00 2001
From: coderzc <zhaocong@apache.org>
Date: Mon, 27 Feb 2023 18:32:30 +0800
Subject: [PATCH] improve logs

---
 .../bucket/BucketDelayedDeliveryTracker.java     | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java
index f24203a954a86..0702adb6f32fc 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java
@@ -233,10 +233,6 @@ private void afterCreateImmutableBucket(Pair<ImmutableBucket, DelayedIndex> immu
             DelayedIndex lastDelayedIndex = immutableBucketDelayedIndexPair.getRight();
             snapshotSegmentLastIndexTable.put(lastDelayedIndex.getLedgerId(), lastDelayedIndex.getEntryId(),
                     immutableBucket);
-            if (log.isDebugEnabled()) {
-                log.debug("[{}] Create bucket snapshot, bucket: {}", dispatcher.getName(),
-                        lastMutableBucket);
-            }
         }
     }
 
@@ -310,8 +306,10 @@ private synchronized CompletableFuture<Void> asyncMergeBucketSnapshot() {
         }
         ImmutableBucket immutableBucketA = values.get(minIndex);
         ImmutableBucket immutableBucketB = values.get(minIndex + 1);
-        log.info("[{}] Merging bucket snapshot, bucketAKey: {}, bucketBKey: {}", dispatcher.getName(),
-                immutableBucketA.bucketKey(), immutableBucketB.bucketKey());
+        if (log.isDebugEnabled()) {
+            log.info("[{}] Merging bucket snapshot, bucketAKey: {}, bucketBKey: {}", dispatcher.getName(),
+                    immutableBucketA.bucketKey(), immutableBucketB.bucketKey());
+        }
         return asyncMergeBucketSnapshot(immutableBucketA, immutableBucketB).whenComplete((__, ex) -> {
             if (ex != null) {
                 log.error("[{}] Failed to merge bucket snapshot, bucketAKey: {}, bucketBKey: {}",
@@ -410,8 +408,10 @@ public synchronized NavigableSet<PositionImpl> getScheduledMessages(int maxMessa
             ImmutableBucket bucket = snapshotSegmentLastIndexTable.remove(ledgerId, entryId);
             if (bucket != null && immutableBuckets.asMapOfRanges().containsValue(bucket)) {
                 final int lastSegmentEntryId = bucket.currentSegmentEntryId;
-                log.info("[{}] Loading next bucket snapshot segment, bucketKey: {}, nextSegmentEntryId: {}",
-                        dispatcher.getName(), bucket.bucketKey(), lastSegmentEntryId + 1);
+                if (log.isDebugEnabled()) {
+                    log.debug("[{}] Loading next bucket snapshot segment, bucketKey: {}, nextSegmentEntryId: {}",
+                            dispatcher.getName(), bucket.bucketKey(), lastSegmentEntryId + 1);
+                }
                 // All message of current snapshot segment are scheduled, load next snapshot segment
                 // TODO make it asynchronous and not blocking this process
                 try {