Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] wireshark build points to wrong pulsar-common directory #179

Closed
1 task done
lin-zhao opened this issue Jan 30, 2023 · 0 comments · Fixed by #182
Closed
1 task done

[Bug] wireshark build points to wrong pulsar-common directory #179

lin-zhao opened this issue Jan 30, 2023 · 0 comments · Fixed by #182

Comments

@lin-zhao
Copy link

Search before asking

  • I searched in the issues and found nothing similar.

Version

3.1.1. Reproduced on M1 macbook pro but it should affect all OS are affected since it's a bad directory link.

Minimal reproduce step

  1. On a M1 macbook, run steps on https://github.com/apache/pulsar-client-cpp to install dependencies.
  2. Run cmake command to prepare wireshark build:
    cmake -DBUILD_WIRESHARK=ON -DGTEST_INCLUDE_PATH=/usr/local/Cellar/googletest/1.13.0/include/gtest -DGMOCK_INCLUDE_PATH=/usr/local/Cellar/googletest/1.13.0/include/gmock .
  3. make pulsar-dissector points to a bad directory for pulsar-common.
make[3]: *** No rule to make target `/Users/lin/git/pulsar-common/src/main/proto/PulsarApi.proto', needed by `generated/lib/PulsarApi.pb.cc'.  Stop.
make[2]: *** [wireshark/CMakeFiles/pulsar-dissector.dir/all] Error 2
make[1]: *** [wireshark/CMakeFiles/pulsar-dissector.dir/rule] Error 2
make: *** [pulsar-dissector] Error 2```

### What did you expect to see?

`make pulsar-dissector` should be successful.

### What did you see instead?

Error message that points to a bad directory for `pulsar-common`.

### Anything else?

This should be caused by the migration from the core pulsar directory. The script need to be updated to point to the right `pulsar-common` source code for `PulsarApi.proto`.

### Are you willing to submit a PR?

- [ ] I'm willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant