Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace akka-paradox plugin with paradox #32

Closed
softinio opened this issue Nov 8, 2022 · 3 comments · Fixed by #91
Closed

Replace akka-paradox plugin with paradox #32

softinio opened this issue Nov 8, 2022 · 3 comments · Fixed by #91
Assignees
Milestone

Comments

@softinio
Copy link
Member

softinio commented Nov 8, 2022

As a quick way to remove the akka branding, lets replace akka-paradox plugin with paradox basic theme. We can make better with more Pekko branding later.

As discussed in #28 with @nvollmar

@softinio
Copy link
Member Author

softinio commented Nov 8, 2022

If no objection, I will start working on this tomorrow.

@He-Pin He-Pin added this to the 1.0.0 milestone Nov 16, 2022
@seglo seglo self-assigned this Jan 7, 2023
@mdedetrich mdedetrich self-assigned this Jan 7, 2023
@mdedetrich
Copy link
Contributor

mdedetrich commented Jan 7, 2023

@seglo @softinio @pjfanning So I tried to do just simply replace the akka paradox theme with the standard one and this made me fall down a rabbit hole. Here are the problems

  • Due to the current Pekko sbt build only loading on an ancient JDK 1.8 version (it actually refuses to load otherwise) we are forced to downgrade to a version of parboiled that is bytecode compatible with JDK 1.8. I have managed to do this locally
  • Although initially it might make sense to just replace addSbtPlugin("com.lightbend.akka" % "sbt-paradox-akka" % "0.44") with the various sbt paradox plugins initially, this will have to be repeated for every single pekko project. Furthermore at some point we would actually like to create a pekko theme, and in order to not repeat boilerplate in the 10+ repos we maintain it makes sense to create a sbt-paradox-pekko sbt plugin akin to sbt-paradox-akka. Initially it can be blank and essentially just contain the following dependencies
    addSbtPlugin("com.lightbend.paradox" % "sbt-paradox" % 0.10.3")
    addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-apidoc" % "1.0.0")
    addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-project-info" % "3.0.0")
    but later on an actual css/js theme can be added. I already have a sample sbt-paradox-pekko locally . The problem here
    is I haven't been able to figure out how to get override the parboiled version when using addSbtPlugin("org.apache.pekko" % "sbt-paradox-pekko" % "HEAD+20230107-1453")

@softinio
Copy link
Member Author

softinio commented Jan 7, 2023

@mdedetrich thanks for pushing this over the finish line. Last quarter I ended having unplanned bandwidth shortage. Happy New Year. Looking forward to contributing this quarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants