grpc 1.68.1 #402
Closed
grpc 1.68.1 #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
Nov 3, 2024
•
pjfanning
commented
- try to workaround issues in Update grpc-core, grpc-interop-testing, ... to 1.68.1 #397 by not updating the grpc name-resolver listener in a Scala future
- there are some issues even after this - similar issues with grpc 1.68.1 enforcing that SynchronizationContext is used and that fails because we use Scala Futures
- since grpc-java 1.68.1, pekko-grpc has issues with RetryingNameResolver (throwIfNotInThisSynchronizationContext) grpc/grpc-java#11662 I suspect the changes in grpc 1.68.1 are too big for us to workaround and that we might need to get grpc team to allow config to disable some of their recent changes
|
the fix is included in 1.68.2 |
Merged
|
replaced by #415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.