Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Aggregation table retract issue #4670

Open
1 of 2 tasks
zhongyujiang opened this issue Dec 9, 2024 · 0 comments
Open
1 of 2 tasks

[Bug] Aggregation table retract issue #4670

zhongyujiang opened this issue Dec 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@zhongyujiang
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Paimon version

master

Compute Engine

core

Minimal reproduce step

Have writen some unit tests to demonstrate this issue, see master...zhongyujiang:incubator-paimon:gh/retract-issue

What doesn't meet your expectations?

The retraction result of the agg table might be incorrect:

  • the early aggregation before write will merge retract records with the same key into a single +I record
  • during compaction, retract records are eliminated, even if there are still records with the same key at lower levels in the LSM tree that are supposed to be retracted

These two points will cause retraction on agg table to fail, please see the unit tests I wrote in the above link.

It seems we need to handle retracts in a similar way to how we handle delete tombstones in LSM, but that would result in both an insert and a delete record for the same key existing within a single sorted run, which might be challenging to handle I guess?

cc @JingsongLi @tsreaper could you please take a look? Thanks

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@zhongyujiang zhongyujiang added the bug Something isn't working label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant