Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose Makefile needs multiple revisions #340

Open
n-hebert opened this issue Apr 15, 2022 · 0 comments
Open

docker-compose Makefile needs multiple revisions #340

n-hebert opened this issue Apr 15, 2022 · 0 comments

Comments

@n-hebert
Copy link

n-hebert commented Apr 15, 2022

Hello 👋, I'm new here.

I noticed a couple errors running the make quick-start, here listed in order of appearance with either "cosmetic" or "fatal" denoting how problematic it is.

  1. (fatal) The make script is not accurately scraping the "running" status from the latest Docker Compose version that I have (2.4.1) -- this leads to an inevitable time-out. I recommend adding an extra clause to grep (-e switch) for the keyword "running", so as to keep backwards compatibility. That would be on lines 308 and 326 (https://github.com/apache/openwhisk-devtools/blob/master/docker-compose/Makefile#L308-L326).
  2. (cosmetic) The echo here is missing a -e so it prints the \n literally instead of a line-break. I recommend using printf, instead, for best functionality with Mac OS.
  3. (fatal) No prerequisites are listed and the makefile will fail if zip isn't installed. This should be listed in the README as a prerequisite.
  4. (fatal) make quick-start under docker-compose hangs #338 blocks, as well (and has done so on the build for quite a while.)
  5. After working around these, I got an error pasted at the very bottom. I tried running the wsk command myself, but it worked fine. Perhaps the Makefile does not wait until the server is ready or reads the return incorrectly.

That's all the time I have to debug for now, hope that's helpful!
I don't currently have an ICLA signed or I would fix these; please anyone who can grab these, go ahead and do so.
Thank you!

Makefile:504: warning: overriding recipe for target 'install-package-alarms'
Makefile:497: warning: ignoring old recipe for target 'install-package-alarms'
Unpacking tarball.
downloading the CLI tool ... 
downloading cli for linux
nightly: Pulling from openwhisk/controller
Digest: sha256:b26cd5a7ea931d79d28899336e07b6e75ec8dd45f1bd1235722de583f45f5827
Status: Image is up to date for openwhisk/controller:nightly
docker.io/openwhisk/controller:nightly
nightly: Pulling from openwhisk/nodejs6action
Digest: sha256:f36f93c2ce7a8c98b7a966e520e0e8eecc8ddeec44471e6ae76b433fc16640a7
Status: Image is up to date for openwhisk/nodejs6action:nightly
docker.io/openwhisk/nodejs6action:nightly
nightly: Pulling from openwhisk/dockerskeleton
Digest: sha256:817ce45d3ef4f817bfe0bbfcabf76200bfe8911d531dc6477a47c1465a88ffdd
Status: Image is up to date for openwhisk/dockerskeleton:nightly
docker.io/openwhisk/dockerskeleton:nightly
pulling the docker images short list... 
nightly: Pulling from openwhisk/invoker
Digest: sha256:af20a0cc5a027d7fae0bfa5da1c0babc92e689260c361e60c71efbcbd336dfc6
Status: Image is up to date for openwhisk/invoker:nightly
docker.io/openwhisk/invoker:nightly
host ip address: 10.0.0.187
checking required ports ... 
 ... OK
  ... preparing api-gateway configuration
pinging minio...
 ... OK
[+] Running 1/0
 ⠿ Container openwhisk-minio-1  Running 0.0s
generating server certificate request
generating self-signed password-less server certificate
Signature ok
subject=C = US, ST = NY, L = Yorktown, O = OpenWhisk, CN = 10.0.0.187
Getting Private key
generate keystore
Waiting till all containers are powered up... 
[+] Running 10/0
 ⠿ Container openwhisk-minio-1            Running 0.0s
 ⠿ Container openwhisk-redis-1            Running 0.0s
 ⠿ Container openwhisk-zookeeper-1        Running 0.0s
 ⠿ Container openwhisk-db-1               Running 0.0s
 ⠿ Container openwhisk-kafka-1            Running 0.0s
 ⠿ Container openwhisk-kafka-rest-1       Running 0.0s
 ⠿ Container openwhisk-kafka-topics-ui-1  Running 0.0s
 ⠿ Container openwhisk-controller-1       Running 0.0s
 ⠿ Container openwhisk-invoker-1          Running 0.0s
 ⠿ Container openwhisk-apigateway-1       Running 0.0s
\nERROR: Timed out waiting for docker services to launch...
make: *** [Makefile:306: wait-for-docker-compose-up] Error 1
ok: created action hello
invoking the function ...
error: Unable to invoke action 'hello': The server is currently unavailable (because it is overloaded or down for maintenance). (code 3teHM9nSSSmW1xkiA5WUWHTestUNYVBo)
Run 'wsk --help' for usage.
ok: deleted action hello
@n-hebert n-hebert changed the title docker-compose output not being parsed correctly docker-compose Makefile needs multiple revisions Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant