Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test for invokerAgent #170

Closed
dgrove-oss opened this issue Mar 24, 2018 · 1 comment
Closed

unit test for invokerAgent #170

dgrove-oss opened this issue Mar 24, 2018 · 1 comment

Comments

@dgrove-oss
Copy link
Member

The invokerAgent added in #155 should have some unit tests, especially of the log route.

Create some tests, possibly restructuring agent to make it easier to mock out the connections to docker/file system, and figure out how to set up go test to actually be able to run them. This may require changing the current build strategy, which is to do a multi-stage Docker build to avoid assuming that there is a Go toolchain installed on the developer's workstation. Or we could do a multi-stack docker build that includes testing as well...

@dgrove-oss
Copy link
Member Author

With the removal of the log route from the invokerAgent, there isn't anything left that can be tested in a unit test. Only function left in the agent is the forwarding of suspend/resume to docker and that code is pretty trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant