chore!: fix typo customed should be customized #4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
shoothzj
approved these changes
Jul 3, 2024
|
Thank you for this PR. I will delay merging it for now since it introduces breaking changes. Perhaps we can also update the reqsign version at the same time. |
|
@Xuanwo would you work on a reqsign fix? Or I may handle it. |
I would appreciate it if you could submit a PR to reqsign. |
|
Here it is - Xuanwo/reqsign#452 |
|
Hi, I want to address #4850 first before start developing of 0.48. So this PR will be hold until then. |
Signed-off-by: tison <[email protected]>
tisonkun
commented
Jul 4, 2024
| @@ -266,7 +266,7 @@ sha1 = { version = "0.10.6", optional = true } | |||
| sha2 = { version = "0.10", optional = true } | |||
|
|
|||
| # For http based services. | |||
| reqsign = { version = "0.15.2", default-features = false, optional = true } | |||
| reqsign = { version = "0.16", default-features = false, optional = true } | |||
There was a problem hiding this comment.
This should be fine now @Xuanwo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Xuanwo There is a similar typo in reqsign also. Please think of if we'd introduce a breaking change to fix it.