From 8faf9ee36e5e30779fc09c124af0978e672f3e88 Mon Sep 17 00:00:00 2001
From: Xuanwo <github@xuanwo.io>
Date: Tue, 18 Jun 2024 18:59:38 +0800
Subject: [PATCH] ci: Disable services-all on windows

Signed-off-by: Xuanwo <github@xuanwo.io>
---
 .github/workflows/ci_bindings_nodejs.yml | 35 ++++++++++++------------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/ci_bindings_nodejs.yml b/.github/workflows/ci_bindings_nodejs.yml
index b5d16e70320..37f4768afaa 100644
--- a/.github/workflows/ci_bindings_nodejs.yml
+++ b/.github/workflows/ci_bindings_nodejs.yml
@@ -80,8 +80,13 @@ jobs:
         run: cargo test --no-fail-fast
 
   linux:
+    name: linux - ${{ matrix.settings.target }}
     runs-on: ubuntu-latest
     if: "startsWith(github.ref, 'refs/tags/')"
+    # Notes: this defaults only apply on run tasks.
+    defaults:
+      run:
+        working-directory: "bindings/nodejs"
     env:
       NAPI_FEATURES: services-all
     strategy:
@@ -129,13 +134,6 @@ jobs:
               # change owner to current user
               sudo chown -R 1001:121 *.node
 
-    # Notes: this defaults only apply on run tasks.
-    defaults:
-      run:
-        working-directory: "bindings/nodejs"
-
-    name: linux - ${{ matrix.settings.target }}
-
     steps:
       - uses: actions/checkout@v4
       - uses: pnpm/action-setup@v4
@@ -161,10 +159,15 @@ jobs:
           path: bindings/nodejs/*.node
 
   windows:
+    name: windows - ${{ matrix.settings.target }}
     runs-on: windows-latest
     if: "startsWith(github.ref, 'refs/tags/')"
-    env:
-      NAPI_FEATURES: services-all
+
+    # Windows built failed with services-all
+    # Wait for https://github.com/apache/opendal/issues/4761
+    # env:
+    #  NAPI_FEATURES: services-all
+
     strategy:
       matrix:
         settings:
@@ -180,7 +183,7 @@ jobs:
       run:
         working-directory: "bindings/nodejs"
 
-    name: windows - ${{ matrix.settings.target }}
+
 
     steps:
       - uses: actions/checkout@v4
@@ -206,8 +209,13 @@ jobs:
           path: bindings/nodejs/*.node
 
   macos:
+    name: macos - ${{ matrix.settings.target }}
     runs-on: macos-latest
     if: "startsWith(github.ref, 'refs/tags/')"
+    # Notes: this defaults only apply on run tasks.
+    defaults:
+      run:
+        working-directory: "bindings/nodejs"
     env:
       NAPI_FEATURES: services-all
     strategy:
@@ -230,13 +238,6 @@ jobs:
               pnpm build
               strip -x *.node
 
-    # Notes: this defaults only apply on run tasks.
-    defaults:
-      run:
-        working-directory: "bindings/nodejs"
-
-    name: macos - ${{ matrix.settings.target }}
-
     steps:
       - uses: actions/checkout@v4
       - uses: pnpm/action-setup@v4