Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add hdfs test case for s3 #4184

Merged
merged 1 commit into from
Feb 16, 2024
Merged

ci: Add hdfs test case for s3 #4184

merged 1 commit into from
Feb 16, 2024

Conversation

ArmandoZ
Copy link
Contributor

@ArmandoZ ArmandoZ commented Feb 15, 2024

Issue: #4168

Adds test case for hdfs over minio s3. Relevant test passed: Behavior Test / core / ubuntu-latest / hdfs / hdfs_default_on_minio_s3

Original PR: #4183

# specific language governing permissions and limitations
# under the License.

name: hdfs_default_s3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename occurrences of s3 to minio_s3 for clarity?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. It still possible for us to add aws_s3 once needed in the future.

@ArmandoZ ArmandoZ marked this pull request as ready for review February 15, 2024 21:13
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, great work!

.github/services/hdfs/hdfs_default_s3/action.yml Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, great work!

@Xuanwo Xuanwo changed the title ci: Add hdfs test case for s3(#4168) ci: Add hdfs test case for s3 Feb 16, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@Xuanwo Xuanwo merged commit 4b315ba into apache:main Feb 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants