Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(service/d1): Add D1Config #4129

Merged
merged 5 commits into from
Feb 2, 2024
Merged

refactor(service/d1): Add D1Config #4129

merged 5 commits into from
Feb 2, 2024

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Feb 2, 2024

Part of #3240

@jihuayu jihuayu requested a review from Xuanwo as a code owner February 2, 2024 02:34
@github-actions github-actions bot requested review from ClSlaid and oowl February 2, 2024 02:34
Xuanwo
Xuanwo approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 775b27c into apache:main Feb 2, 2024
46 checks passed
@suyanhanx suyanhanx mentioned this pull request Feb 2, 2024
Closed
47 tasks
@jihuayu jihuayu deleted the f/0202-d1config branch February 8, 2024 02:53
@Xuanwo Xuanwo mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@oowl oowl Awaiting requested review from oowl

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jihuayu @Xuanwo