feat(binding/C): add clang-format for c binding #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ji-Xinyou <[email protected]>
* Format all C source code and headers using clang-format Signed-off-by: Ji-Xinyou <[email protected]>
xyjixyjixyji
requested review from
Xuanwo,
PsiACE,
ClSlaid and
sundy-li
as code owners
|
Just two quick questions, 1. do we need |
PsiACE
reviewed
Apr 15, 2023
When we enable CI for the c binding, we can add it.
If this file can have comments, please do so. |
xyjixyjixyji
force-pushed
the
clang-format
branch
from
d28e128
to
9a8524a
Compare
|
The licence header is added now. Then the format check should be done in future PRs related to binding CI. 😄 |
* Remove the space of assigning envvar in Makefile * Add `make format` command to format all "*.c" and ".h" file under the c binding directory Signed-off-by: Ji-Xinyou <[email protected]>
xyjixyjixyji
force-pushed
the
clang-format
branch
from
9a8524a
to
1b5050b
Compare
Signed-off-by: Ji-Xinyou <[email protected]>
ClSlaid
approved these changes
Apr 15, 2023
Signed-off-by: Ji-Xinyou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make formatto format all .c and .h fileFixed: #1992