Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/gcs): Add customed token loader support #1908

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 11, 2023

No description provided.

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need more doc

core/src/services/gcs/backend.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 11, 2023

May need more doc

reqsign is not stable yet, we just expose this function directly. We could add our own trait instead.

@Xuanwo Xuanwo merged commit cf30d6e into main Apr 11, 2023
@Xuanwo Xuanwo deleted the fix-gcs-api branch April 11, 2023 11:29
wcy-fdu pushed a commit to wcy-fdu/opendal that referenced this pull request Apr 12, 2023
* feat(services/gcs): Add customed token loader support

Signed-off-by: Xuanwo <[email protected]>

* Update core/src/services/gcs/backend.rs

Co-authored-by: Suyan <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>
Co-authored-by: Suyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants