Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Forward port #19895 #19903

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Forward port #19895 #19903

merged 2 commits into from
Feb 19, 2021

Commits on Feb 16, 2021

  1. [v1.x] CI fixes to make more stable and upgradable (apache#19895)

    * Test moving pipelines from p3 to g4.
    
    * Remove fallback codecov command - the existing (first) command works and the second always fails a few times before finally succeeding (and also doesn't support the -P parameter, which causes an error.)
    
    * Stop using docker python client, since it still doesn't support latest nvidia 'gpus' attribute. Switch to using subprocess calls using list parameter (to avoid shell injections).
    
    See docker/docker-py#2395
    
    * Remove old files.
    
    * Fix comment
    
    * Set default environment variables
    
    * Fix GPU syntax.
    
    * Use subprocess.run and redirect output to stdout, don't run docker in interactive mode.
    
    * Check if codecov works without providing parameters now.
    
    * Send docker stderr to sys.stderr
    
    * Support both nvidia-docker configurations, first try '--gpus all', and if that fails, then try '--runtime nvidia'.
    
    Co-authored-by: Joe Evans <[email protected]>
    josephevans and Joe Evans committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    0303587 View commit details
    Browse the repository at this point in the history
  2. Fix merge

    Joe Evans committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d6db57f View commit details
    Browse the repository at this point in the history