This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Stop packaging GPL libquadmath.so #19053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [centos-gpu, unix-cpu, clang, unix-gpu, sanity, windows-gpu, miscellaneous, edge, website, windows-cpu, centos-cpu] Note: |
|
@leezu can we update the docs too with this PR to say that libquadmath.so is needed and how users can install it? |
samskalicky
approved these changes
Aug 31, 2020
leezu
added a commit
to leezu/mxnet
that referenced
this pull request
Aug 31, 2020
libquadmath.so is GPL and must not be distributed by Apache projects. Users will need to ensure that libquadmath.so is present on their systems if they use binary builds of MXNet. libquadmath.so has not yet undergone any ABI changes, thus all versions of libquadmath.so are ABI compatible and user just needs to install system version of libquadmath.so. libgfortran.so can be packaged thanks to GCC Runtime Library Exception. See https://www.apache.org/legal/resolved.html#category-x
leezu
added a commit
that referenced
this pull request
Sep 1, 2020
* Stop packaging GPL libquadmath.so (#19053) libquadmath.so is GPL and must not be distributed by Apache projects. Users will need to ensure that libquadmath.so is present on their systems if they use binary builds of MXNet. libquadmath.so has not yet undergone any ABI changes, thus all versions of libquadmath.so are ABI compatible and user just needs to install system version of libquadmath.so. libgfortran.so can be packaged thanks to GCC Runtime Library Exception. See https://www.apache.org/legal/resolved.html#category-x * Remove unmaintained pip packages * Workaround pypa/setuptools#2352
mseth10
added a commit
to mseth10/incubator-mxnet
that referenced
this pull request
May 12, 2021
mseth10
added a commit
that referenced
this pull request
May 12, 2021
* add aarch64 build support * add publish dockerfile * add options to build mkldnn w/ apl and acl add options to build mkldnn w/ arm performance libraries and arm compute library * remove libquadmath due to licensing issues #19053 Co-authored-by: Zhaoqi Zhu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libquadmath.so is GPL and must not be distributed by Apache projects. Users will need to ensure that libquadmath.so is present on their systems if they use binary builds of MXNet. libquadmath.so has not yet undergone any ABI changes, thus all versions of libquadmath.so are ABI compatible and user just needs to install system version of libquadmath.so.
libgfortran.so can be packaged thanks to GCC Runtime Library Exception. See https://issues.apache.org/jira/browse/LEGAL-523
See https://www.apache.org/legal/resolved.html#category-x