Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove Makefile #18721

Merged
merged 6 commits into from
Jul 20, 2020
Merged

Remove Makefile #18721

merged 6 commits into from
Jul 20, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jul 15, 2020

Replaced by cmake build. See #16167

@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, clang, unix-gpu, sanity, windows-cpu, unix-cpu, miscellaneous, centos-gpu, website, edge, windows-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

Makefile Show resolved Hide resolved
@leezu
Copy link
Contributor Author

leezu commented Jul 17, 2020

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu]

@leezu
Copy link
Contributor Author

leezu commented Jul 18, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, sanity, unix-cpu, miscellaneous, unix-gpu, centos-gpu, windows-cpu, clang, website, centos-cpu, windows-gpu]

@szha
Copy link
Member

szha commented Jul 18, 2020

Developers may still need to rely on some of the Makefile targets for development purpose. Make sure that they are documented prominently, as we can't ask developers to read the CI code first when starting with out project.

@leezu
Copy link
Contributor Author

leezu commented Jul 20, 2020

The Makefile targets are undocumented and are tied to the CI:

https://github.com/apache/incubator-mxnet/blob/faccd91071cc34ed0b3a192d3c7932441fe7e35e/ci/docker/install/requirements#L35-L36

For now using the python ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh sanity_check or manually running pylint and cpplint should be acceptable. We can have a separate PR that removes the technical debt of the linting system (#17968 (comment)). For pylint, just moving ci/other/pylintrc to the root of the repo should be sufficient. For cpplint, we need to migrate to clang-format and cmake will run it automatically.

@leezu leezu merged commit a7c6606 into apache:master Jul 20, 2020
@leezu leezu deleted the removemakefile branch July 20, 2020 23:06
@szha
Copy link
Member

szha commented Jul 21, 2020

Thanks for elaborating. Would you update the document here to reflect this? https://cwiki.apache.org/confluence/display/MXNET/Development+Process
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=125309983&src=contextnavpagetreemode

There probably are a number of other pages that reference the use of make that we should clean up. Searching in cwiki should reveal them.

@leezu
Copy link
Contributor Author

leezu commented Jul 21, 2020

I updated the https://cwiki.apache.org/confluence/display/MXNET/Development+Process and
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=125309983&src=contextnavpagetreemode
Searching through the wiki didn't yield other obvious references to the Makefile

chinakook pushed a commit to chinakook/mxnet that referenced this pull request Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants