-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Remove out-dated examples using mx.module #18446
Conversation
Hey @eric-haibin-lin , Thanks for submitting the PR
CI supported jobs: [centos-gpu, clang, miscellaneous, unix-gpu, website, windows-cpu, windows-gpu, unix-cpu, sanity, edge, centos-cpu] Note: |
While we remove the outdated examples [as module api is no longer supported], would it be a good idea to update these examples to use the correct API [replacement of module] instead of removing these examples altogether? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChaiBapchya as you can see the number of examples affected is large and it requires lots of efforts to rewrite all of them. While I am happy to create a github issue listing them and welcome contribution from the community, one problem is that these examples are not really tested in the CI pipeline, which makes it hard to maintain
Right. One issue MXNet users face is the lack of examples & documentation around it. Makes sense to create a Github Issue to call for contributions from the community. |
created an issue #18458 |
@ChaiBapchya I think another issue is the prevalence of outdated examples. As developers can always access the outdated examples via the git history and the list of examples is tracked in #18458, let's merge this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The factorization machine module is quite useful. Is it possible to bring back under Gluon? Thanks.
Isn't this the problem to solve? |
Testing all these examples in CI is
Having said that, if someone in the community is willing to volunteer to |
If people haven't built it, it seems to be a useful tool to have. |
Description
After https://github.com/apache/incubator-mxnet/pull/18394/files, we have removed the
mx.model.Feedforward
API and related examples. Following #17676, there will be a series of PRs that enhances Gluon execution & removing mx.module API for mxnet 2.0. In this PR, I am removing most of the examples thatmxnet.module.Module
APIs for model training, andChecklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments