This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @sxjscience , Thanks for submitting the PR
CI supported jobs: [unix-gpu, sanity, unix-cpu, windows-gpu, miscellaneous, website, centos-cpu, centos-gpu, windows-cpu, clang, edge] Note: |
@xinyu-intel I think the fix should also be in 1.7. |
@sxjscience 1.7 doesn't contain #17679 , you can cherry-pick this patch to v1.x when #18160 merged. |
Update basic_layers.py fix fix Update basic_layers.py fix bug
wkcn
approved these changes
May 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
xinyu-intel
pushed a commit
to xinyu-intel/incubator-mxnet
that referenced
this pull request
Jun 2, 2020
Update basic_layers.py fix fix Update basic_layers.py fix bug
7 tasks
pengzhao-intel
pushed a commit
that referenced
this pull request
Jun 3, 2020
Update basic_layers.py fix fix Update basic_layers.py fix bug Co-authored-by: Xingjian Shi <[email protected]>
yijunc
pushed a commit
to yijunc/incubator-mxnet
that referenced
this pull request
Jun 9, 2020
Update basic_layers.py fix fix Update basic_layers.py fix bug
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
Update basic_layers.py fix fix Update basic_layers.py fix bug
chinakook
pushed a commit
to chinakook/mxnet
that referenced
this pull request
Jul 24, 2020
Update basic_layers.py fix fix Update basic_layers.py fix bug
ChaiBapchya
pushed a commit
to ChaiBapchya/mxnet
that referenced
this pull request
Aug 15, 2020
Update basic_layers.py fix fix Update basic_layers.py fix bug Co-authored-by: Xingjian Shi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #18373.
The PR #17679 introduced the bug @xinyu-intel
@nttstar Should fix your problem.