Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix BatchNorm #18377

Merged
merged 2 commits into from
May 31, 2020
Merged

Fix BatchNorm #18377

merged 2 commits into from
May 31, 2020

Conversation

sxjscience
Copy link
Member

Description

Fix #18373.

The PR #17679 introduced the bug @xinyu-intel

@nttstar Should fix your problem.

@sxjscience sxjscience requested a review from szha as a code owner May 21, 2020 05:30
@mxnet-bot
Copy link

Hey @sxjscience , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, sanity, unix-cpu, windows-gpu, miscellaneous, website, centos-cpu, centos-gpu, windows-cpu, clang, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@sxjscience
Copy link
Member Author

@xinyu-intel I think the fix should also be in 1.7.

@xinyu-intel
Copy link
Contributor

@sxjscience 1.7 doesn't contain #17679 , you can cherry-pick this patch to v1.x when #18160 merged.

Update basic_layers.py

fix

fix

Update basic_layers.py

fix bug
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@sxjscience sxjscience merged commit 8174771 into apache:master May 31, 2020
xinyu-intel pushed a commit to xinyu-intel/incubator-mxnet that referenced this pull request Jun 2, 2020
Update basic_layers.py

fix

fix

Update basic_layers.py

fix bug
pengzhao-intel pushed a commit that referenced this pull request Jun 3, 2020
Update basic_layers.py

fix

fix

Update basic_layers.py

fix bug

Co-authored-by: Xingjian Shi <[email protected]>
yijunc pushed a commit to yijunc/incubator-mxnet that referenced this pull request Jun 9, 2020
Update basic_layers.py

fix

fix

Update basic_layers.py

fix bug
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
Update basic_layers.py

fix

fix

Update basic_layers.py

fix bug
chinakook pushed a commit to chinakook/mxnet that referenced this pull request Jul 24, 2020
Update basic_layers.py

fix

fix

Update basic_layers.py

fix bug
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
Update basic_layers.py

fix

fix

Update basic_layers.py

fix bug

Co-authored-by: Xingjian Shi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Numpy] The symbolic export of BatchNorm is wrong
4 participants