Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix CUDNN GPU tests #14595

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Apr 2, 2019

Description

Currently, the GPU tests do not use the CUDNN_VERSION environment variable supplied by the CUDA base image used by the GPU test containers. This PR mitigates this by only manually setting the cuDNN version if it currently does not already exist in the environment.

Taking this functionality out of #14513 and into its own PR to ensure the issues I'm experiencing in #14513 are not related to this CUDNN_VERSION variable problem.

@perdasilva perdasilva changed the title [WIP] Fix CUDNN GPU tests Fix CUDNN GPU tests Apr 2, 2019
@piyushghai
Copy link
Contributor

Thanks for fixing these @perdasilva
@mxnet-label-bot Add [CI, pr-awaiting-merge]

@marcoabreu marcoabreu added CI pr-awaiting-merge Review and CI is complete. Ready to Merge labels Apr 2, 2019
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkcn wkcn merged commit dde77d4 into apache:master Apr 3, 2019
@wkcn
Copy link
Member

wkcn commented Apr 3, 2019

The PR has been merged.
Thank you for the fix!

ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
nswamy pushed a commit that referenced this pull request Apr 5, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants