Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-810] Add support for more req patterns for bilinear sampler backward #12386

Merged
merged 1 commit into from
Sep 11, 2018
Merged

[MXNET-810] Add support for more req patterns for bilinear sampler backward #12386

merged 1 commit into from
Sep 11, 2018

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Aug 28, 2018 •
edited
Loading

Description

Fix #8866.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Support more req type patterns for backward of bilinear sampler
  • Corresponding unit tests

Comments

Added test case also passed flakiness check

MXNET_TEST_COUNT=10000 nosetests -s --verbose tests/python/gpu/test_operator_gpu.py:test_bilinear_sampler_versions

[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=583854465 to reproduce.
test_operator_gpu.test_bilinear_sampler_versions ... ok

----------------------------------------------------------------------
Ran 1 test in 539.629s

OK

@haojin2 haojin2 requested a review from anirudh2290 as a code owner August 28, 2018 23:02
@haojin2
Copy link
Contributor Author

haojin2 commented Aug 28, 2018

@eric-haibin-lin @reminisce @piiswrong @anirudh2290

@haojin2 haojin2 force-pushed the bilinear_req_support branch from 830d788 to 4da6c55 Compare August 28, 2018 23:06
@haojin2 haojin2 mentioned this pull request Aug 28, 2018
Closed
@haojin2 haojin2 force-pushed the bilinear_req_support branch from 4da6c55 to 034a6cf Compare September 6, 2018 21:50
@haojin2 haojin2 changed the title [MXNET-810] [WIP] Add support for more req patterns for bilinear sampler backward [MXNET-810] Add support for more req patterns for bilinear sampler backward Sep 6, 2018
@haojin2 haojin2 force-pushed the bilinear_req_support branch from 034a6cf to b9c5da1 Compare September 7, 2018 21:31
@haojin2 haojin2 force-pushed the bilinear_req_support branch from b9c5da1 to 2cd7e12 Compare September 10, 2018 22:43
@haojin2
Copy link
Contributor Author

haojin2 commented Sep 11, 2018

@anirudh2290 @eric-haibin-lin Should be good for merge?

@anirudh2290 anirudh2290 merged commit 4ee866f into apache:master Sep 11, 2018
@haojin2 haojin2 deleted the bilinear_req_support branch September 11, 2018 17:21
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Sep 11, 2018
@haojin2 @aaronmarkham
Add support for more req patterns for bilinear sampler backward (apac…
6132aa2 
…he#12386)
zhreshold added a commit that referenced this pull request Sep 12, 2018
@zhreshold
Revert "Add support for more req patterns for bilinear sampler backwa…
efb6c98 
…rd (#12386)"

This reverts commit 4ee866f.
szha pushed a commit that referenced this pull request Sep 12, 2018
@zhreshold @szha
Revert "Change the way NDArrayIter handle the last batch" (#12537)
8ff50c9 
* Revert "Removing the re-size for validation data, which breaking the validation accuracy of CIFAR training (#12362)"

This reverts commit ceabcaa.

* Revert "[MXNET-580] Add SN-GAN example (#12419)"

This reverts commit 46a5cee.

* Revert "Remove regression checks for website links (#12507)"

This reverts commit 619bc3e.

* Revert "Revert "Fix flaky test: test_mkldnn.test_activation #12377 (#12418)" (#12516)"

This reverts commit 7ea0533.

* Revert "further bump up tolerance for sparse dot (#12527)"

This reverts commit 90599e1.

* Revert "Fix broken URLs (#12508)"

This reverts commit 3d83c89.

* Revert "Temporarily disable flaky tests (#12520)"

This reverts commit 35ca13c.

* Revert "Add support for more req patterns for bilinear sampler backward (#12386)"

This reverts commit 4ee866f.

* Revert "Change the way NDArrayIter handle the last batch (#12285)"

This reverts commit 597a637.
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@haojin2 @anirudh2290
Add support for more req patterns for bilinear sampler backward (apac…
3df22a8 
…he#12386)
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@zhreshold @anirudh2290
Revert "Change the way NDArrayIter handle the last batch" (apache#12537)
4c634e0 
* Revert "Removing the re-size for validation data, which breaking the validation accuracy of CIFAR training (apache#12362)"

This reverts commit ceabcaa.

* Revert "[MXNET-580] Add SN-GAN example (apache#12419)"

This reverts commit 46a5cee.

* Revert "Remove regression checks for website links (apache#12507)"

This reverts commit 619bc3e.

* Revert "Revert "Fix flaky test: test_mkldnn.test_activation apache#12377 (apache#12418)" (apache#12516)"

This reverts commit 7ea0533.

* Revert "further bump up tolerance for sparse dot (apache#12527)"

This reverts commit 90599e1.

* Revert "Fix broken URLs (apache#12508)"

This reverts commit 3d83c89.

* Revert "Temporarily disable flaky tests (apache#12520)"

This reverts commit 35ca13c.

* Revert "Add support for more req patterns for bilinear sampler backward (apache#12386)"

This reverts commit 4ee866f.

* Revert "Change the way NDArrayIter handle the last batch (apache#12285)"

This reverts commit 597a637.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin left review comments

@anirudh2290 anirudh2290 anirudh2290 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@haojin2 @anirudh2290 @eric-haibin-lin