Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update fit.py #10685

Merged
merged 2 commits into from
May 3, 2018
Merged

Update fit.py #10685

merged 2 commits into from
May 3, 2018

Conversation

arundasan91
Copy link
Contributor

Description

args.network is None during finetuing using fine-tune.py file which is provided. Hence, line 241 throws an error while trying to see if 'vgg' is in args.network. Patching it by checking if args.network is None before seeing if 'vgg' is present in network name.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@arundasan91
Update fit.py
49c061f 
args.network is None during finetuing using fine-tune.py file which is provided. Hence, line 241 throws an error while trying to see if 'vgg' is in args.network. Patching it by checking if args.network is None before seeing if 'vgg' is present in network name.
@arundasan91 arundasan91 requested a review from szha as a code owner April 25, 2018 14:35
rahul003
rahul003 reviewed Apr 26, 2018
View reviewed changes
example/image-classification/common/fit.py Outdated
@@ -238,7 +238,7 @@ def fit(args, network, data_loader, **kwargs):
# AlexNet will not converge using Xavier
initializer = mx.init.Normal()
# VGG will not trend to converge using Xavier-Gaussian
elif 'vgg' in args.network:
elif args.network != None and 'vgg' in args.network:
Copy link
Member

@rahul003 rahul003 Apr 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be cleaner and more pythonic if you did elif args.network and 'vgg' in args.network

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is vey correct. Thanks.

@szha szha merged commit 9dce757 into apache:master May 3, 2018
marcoabreu added a commit that referenced this pull request May 3, 2018
@marcoabreu
Revert "Update fit.py (#10685)"
19cbccc 
This reverts commit 9dce757.
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 7, 2018
@arundasan91 @anirudh2290
Update fit.py (apache#10685)
78ba0e7 
* Update fit.py

args.network is None during finetuing using fine-tune.py file which is provided. Hence, line 241 throws an error while trying to see if 'vgg' is in args.network. Patching it by checking if args.network is None before seeing if 'vgg' is present in network name.

* Update fit.py
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request May 29, 2018
@arundasan91
Update fit.py (apache#10685)
7f4fff7 
* Update fit.py

args.network is None during finetuing using fine-tune.py file which is provided. Hence, line 241 throws an error while trying to see if 'vgg' is in args.network. Patching it by checking if args.network is None before seeing if 'vgg' is present in network name.

* Update fit.py
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@arundasan91 @szha
Update fit.py (apache#10685)
8a79428 
* Update fit.py

args.network is None during finetuing using fine-tune.py file which is provided. Hence, line 241 throws an error while trying to see if 'vgg' is in args.network. Patching it by checking if args.network is None before seeing if 'vgg' is present in network name.

* Update fit.py
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@arundasan91 @zheng-da
Update fit.py (apache#10685)
060b780 
* Update fit.py

args.network is None during finetuing using fine-tune.py file which is provided. Hence, line 241 throws an error while trying to see if 'vgg' is in args.network. Patching it by checking if args.network is None before seeing if 'vgg' is present in network name.

* Update fit.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rahul003 rahul003 rahul003 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arundasan91 @rahul003 @szha