Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Can't press down arrow in search results dropdown on https://mxnet.incubator.apache.org/ #10402

Closed
jaanli opened this issue Apr 4, 2018 · 5 comments

Comments

@jaanli
Copy link

jaanli commented Apr 4, 2018

It would improve UX to be able to press the down arrow in the dropdown that appears when we search https://mxnet.incubator.apache.org/

@marcoabreu
Copy link
Contributor

@aaronmarkham

@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented May 5, 2020

@ys2843 has this been taken care of with #18188?

@ys2843
Copy link
Contributor

ys2843 commented Jun 18, 2020

@aaronmarkham @marcoabreu Global search now supports keyboard control (up/down arrow select). This issue can be closed.

@ChaiBapchya
Copy link
Contributor

Thanks for adding the functionality Yang!
Can you point to which PR added keyboard control? Was it different from the one I mentioned above?

@ys2843
Copy link
Contributor

ys2843 commented Jun 19, 2020

@ChaiBapchya I assume it is the dropdown of the search feature on the top navigation bar that need keyboard control. v1.6+ website has new global search feature #18288 which support navigating through results by pressing up/down arrow key.

@szha szha closed this as completed Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants